-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update play queue metadata #2453
Conversation
@Stypox the title and mediaId are set in the constructor a few lines above. I was first excited when I saw this PR as I was the one that introduced the "additionalMetadata" bundle but getDuration didn't work for me. But I am happy that it works for you @m0n1ker edit: maybe we should still put METADATA_KEY_TITLE in case this field is read by some awkward bluetooth devices? |
@Stypox This might help #1467, but I kind of doubt it. I'm running android 9 on a Galaxy S9 and it does not show the media controls as described in the issue. I only see the notification widget, which is working for me, so I'm not able to test this specific issue on my device. As far as #228, again I think it will make the exposed metadata more reliable but I'm not sure this really resolves the feature request as stated. I looked at adding the album art to the metadata, but it was causing some other issues that I haven't been able to solve. If I can get that working I can submit another PR for it. @Redirion I'm surprised this didn't change anything in your car. It's new enough it should be able to correctly handle metadata, but bluetooth receivers are weird sometimes. I've verified the metadata being sent with the I agree that adding |
As an additional note, I think the issue with #228 has more to do with the fact this app is implementing |
@m0n1ker Thanks! The code looks good.
Yes, that could solve the problems. I am glad that you want to take a look at it. Is someone capable of testing this with a different car or device? I don't own a car which supports Bluetooth. If not, this shouldn't be a problem, because the changes don't look like they can break something. |
This PR includes
item.getDuration()
returns the duration in seconds, while the metadata object expects this to be in milliseconds.These metadata changes have been tested using a Pioneer car stereo over Bluetooth.
Fixes #2240